Extend precession test with a second epoch one second later#4863
Open
IsseiHasegawa wants to merge 2 commits into
Open
Extend precession test with a second epoch one second later#4863IsseiHasegawa wants to merge 2 commits into
IsseiHasegawa wants to merge 2 commits into
Conversation
The paper table only gives vectors for one JD; repeat the PQXY vs Capitaine matrix comparison for JD + 1s without duplicating tabulated constants. Made-with: Cursor
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
gzotti
reviewed
Apr 8, 2026
| // according to Fig12 in the paper, a few arcseconds of difference between PQXY and Capitaine parametrisation are allowed. | ||
| QVERIFY2((angleCap-angleRef)*3600.0<6.0, QString("Angle between rotation matrices too different!").toUtf8()); | ||
|
|
||
| //TODO: Add more dates and verify this angle difference is limited to what we can see in Fig.12 |
Member
There was a problem hiding this comment.
Adding the same dates plus one second IMO does not qualify to remove the intent of the TODO message. Adding a few centuries might do it, but we have no "official" reference values.
gzotti
reviewed
Apr 8, 2026
| * Foundation, Inc., 51 Franklin Street, Suite 500, Boston, MA 02110-1335, USA. | ||
| */ | ||
|
|
||
| #include <QObject> |
Member
There was a problem hiding this comment.
These includes were probably used by code now only commented away, and will be needed when taking up development in case any doubts in the precession model appear.
Member
|
TBH I don't see the point here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend precession test with a second epoch (JD + 1s)
The paper table only gives vectors for one JD; repeat the PQXY vs Capitaine matrix comparison for JD + 1s without duplicating tabulated constants.
Made-with: Cursor
Description
TestPrecession::testPrecessionAnglesVondrak()insrc/tests/testPrecession.cpp.JD + 1 second.Fixes # (none — add issue number if you opened one)
Screenshots (if appropriate):
N/A
Type of change
How Has This Been Tested?
testPrecessiontarget and ran:ctest --test-dir build-test --output-on-failure -R testPrecessiontestPrecessionpassed.Test Configuration:
Checklist: